Feat/#575 스크립트를 로드하는 유틸 함수 구현 #576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruelladevil
requested review from
Creative-Lee and
ukkodeveloper
as code owners
ukkodeveloper
requested changes
Nov 13, 2024
Comment on lines
+11
to
+12
| script.async = true; | ||
| script.defer = true; |
There was a problem hiding this comment.
script.async = true; 만 있어도 될 것 같아요. (참고)
Comment on lines
+14
to
+15
| script.onload = () => resolve(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| script.onload = () => resolve(); | |
| script.onerror = (error) => reject(error); |
script 로드에 실패했을 때 에러 처리가 필요해 보입니다.
Comment on lines
+2
to
+7
| const element = document.querySelector(`script[src="${source}"]`); | ||
|
|
||
| if (element) { | ||
| return Promise.resolve(); | ||
| } | ||
|
|
There was a problem hiding this comment.
같은 src로 동시에 여러번 loadScript를 호출하면 어떻게 되나요?
load중일 때에는 아직 element가 만들어지기 전이라서, 같은 script를 여러 개를 만들 것 같아요. flag를 두어서 중복생성하지 않도록 막아주는 게 좋을 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
스크립트를 로드하는 유틸 함수 구현
💬리뷰 참고사항
#️⃣연관된 이슈
close #575