Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ OfferingPrice 검증과정 순서 조정 #213

Open
1 task
masonkimseoul opened this issue Aug 7, 2024 · 0 comments
Open
1 task

♻️ OfferingPrice 검증과정 순서 조정 #213

masonkimseoul opened this issue Aug 7, 2024 · 0 comments
Assignees

Comments

@masonkimseoul
Copy link
Member

📌 Description

원가 - 엔빵가격 검증과정 위치 조정

public Long saveOffering(OfferingSaveRequest request, MemberEntity member) {
        OfferingEntity offering = request.toEntity(member);
        OfferingPrice offeringPrice = offering.toOfferingPrice();
        offeringPrice.validateOriginPrice();

검증과정의 순서를 조정하면 좋을 것 같습니다.
request에서 OfferingPrice를 먼저 만들고, 검증 이후에 OfferingEntity를 만드는게 어떤가요? 차차 생각해봅시다.

📝 To-do

  • 논의

예상 소요 시간

  • 0.5h
  • 1h
  • 1.5h
  • 2h
  • 2.5h
  • 3h+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants