-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds session helpers #384
base: main
Are you sure you want to change the base?
Adds session helpers #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding! Left a bunch of comments inline, but most are minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! There's still two outstanding comments regarding List vs. Sequence in /types/user_management/session.py, but nothing new from second pass.
Fixes #350
Description
Adds new session helpers. Example API:
Also makes it so dependencies are loaded from
requirements.txt
rather than hardcoded insetup.py
.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.