Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reprun: Crash when ado-file or program executed directly #11

Open
Tracked by #5 ...
bbdaniels opened this issue Nov 30, 2023 · 5 comments
Open
Tracked by #5 ...

reprun: Crash when ado-file or program executed directly #11

bbdaniels opened this issue Nov 30, 2023 · 5 comments
Assignees
Labels
bug Something isn't working reprun Relates to reprun
Milestone

Comments

@bbdaniels
Copy link
Contributor

Haven't reproduced this yet, but when I ran an ado-file directly during a reprun call, it later got into a bizarre loop calling reprun_dataline, I can't figure out the reason yet.

For example, the following is in the main do-file:

// Installs for user-written packages

  qui do "${git}/do/labelcollapse.ado"

When I later called labelcollapse ... things went off the rails. Files at https://github.com/bbdaniels/sdi-health

@bbdaniels bbdaniels added the bug Something isn't working label Nov 30, 2023
@bbdaniels
Copy link
Contributor Author

This occurs similarly if I am defining a program in-line using program.

@bbdaniels bbdaniels changed the title reprun: Unknown crash when ado-file executed directly reprun: Crash when ado-file or program executed directly Nov 30, 2023
@kbjarkefur
Copy link
Contributor

It seems to me as the solution to this should be that as long as we fix #14 we should solve this by not calling reprun recursively on .ado files

@kbjarkefur
Copy link
Contributor

However, that wont solve the case when programs are defined in a dofile. So maybe the full and most bullet prrof solution is to keep track of a program definition and not write reprun_dataline between program define and end.

@bbdaniels
Copy link
Contributor Author

I think that is right. And I think it is also right that this should be relatively straightforward since program is never nested so very little counting is needed as well?

@bbdaniels bbdaniels removed their assignment Feb 1, 2024
@kbjarkefur kbjarkefur added the reprun Relates to reprun label Apr 16, 2024
@kbjarkefur kbjarkefur added this to the reprun first full release milestone Apr 16, 2024
@ankritisingh
Copy link
Contributor

Is this one done or should this be moved to next-release?

@ankritisingh ankritisingh modified the milestones: v2.2, next-release Jul 30, 2024
@ankritisingh ankritisingh modified the milestones: v3.0, next-release Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reprun Relates to reprun
Projects
None yet
Development

No branches or pull requests

3 participants