Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequencer API should return HTTP statuses other than 400 #496

Open
cichaczem opened this issue Apr 25, 2023 · 1 comment
Open

Sequencer API should return HTTP statuses other than 400 #496

cichaczem opened this issue Apr 25, 2023 · 1 comment

Comments

@cichaczem
Copy link
Contributor

cichaczem commented Apr 25, 2023 •
edited
Loading

We want to return

  • 401 when basic auth credentials are incorrect. Let's check with Infra if that's done.
  • 400 when the request body can't be parsed/validated. E.g. invalid JSON request: invalid type: integer 1, expected a 32 byte hex string at line 1 column 3
  • 409 when any ServerError occurs. Double-check with the code if it makes sense

Related code
@cichaczem cichaczem assigned cichaczem and unassigned cichaczem Apr 25, 2023
@mahmudsudo
Copy link

can i take up this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cichaczem @mahmudsudo