Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 deprecation: Implicitly nullable parameter declarations #997

Closed
MohamadNateqi opened this issue Jan 8, 2025 · 2 comments
Closed

PHP 8.4 deprecation: Implicitly nullable parameter declarations #997

MohamadNateqi opened this issue Jan 8, 2025 · 2 comments
Assignees
@MohamadNateqi
Labels
compatibility

Comments

@MohamadNateqi
Copy link
Contributor 

PHP Deprecated:  WPO\IPS\Vendor\Dompdf\Options::__construct(): Implicitly marking parameter $attributes as nullable is deprecated, the explicit nullable type must be used instead in ...\wp-content\plugins\woocommerce-pdf-invoices-packing-slips\vendor\dompdf\dompdf\src\Options.php on line 335

The dompdf library needs to be updated to v3.0.2 for better compatibility with PHP 8.4.
@alexmigf
Copy link
Member

alexmigf commented Jan 8, 2025

This upgrade is already being tracked: #937.

The Plugin Check PR needs to be merged first, so this will likely be included in version 3.9.7.

@MohamadNateqi
Copy link
Contributor Author

Closed in favor of #937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohamadNateqi MohamadNateqi

Labels
compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexmigf @MohamadNateqi