Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PHP 8.1 & Node 16 #315

Closed
tormi opened this issue Sep 29, 2022 · 4 comments
Closed

Upgrade to PHP 8.1 & Node 16 #315

tormi opened this issue Sep 29, 2022 · 4 comments
Assignees

Comments

@tormi
Copy link
Member

tormi commented Sep 29, 2022

Let's upgrade the defaults to PHP 8.1 & Node 16.

@tormi tormi self-assigned this Sep 29, 2022
@tormi
Copy link
Member Author

tormi commented Sep 30, 2022

PHP versions 8.1.0 to 8.1.5 have an OPcache bug that can cause fatal errors with class autoloading. It can be avoided by using PHP 8.1.6 or later.

@tormi
Copy link
Member Author

tormi commented Sep 30, 2022

Instana currently does not support PHP 8.1.

@tormi
Copy link
Member Author

tormi commented Sep 30, 2022

Hannes Kirsman
Lessons learned from going to PHP 8.0, 8.1

  • Going for PHP 8.0 went much smoother
  • 8.1 is suggested by Drupal core but it'll flood logs with deprecated code warnings
  • In one of our sites we have drupal.log on disk. Usually it's 4-5 GB per month. Now it was 34GB and it was not even end of month. There were over 1 million logs per day.
  • Some modules that need updating: Redirect, Token, Webform, Typed Data API enhancements, CSV Serialization, Rabbit Hole etc. Probably also your custom modules. For some modules you probably need patching. We even added one core patch https://www.drupal.org/project/drupal/issues/3264979
  • At least one warning is coming from vendor package PHP8 deprecation warnings hechoendrupal/drupal-console-core#388
  • Our Code Quality tool won't catch many errors because it does not know what the actual values are that are passed around
  • Some warnings seems to come from core but it's actually t() methods where there are arguments that are sometimes empty. Eg return t('Hello @world', array('@world' => $var_that_is_null_for_some_reason)); These null values are sent for PHP methods like htmlspecialchars() and voila - you have deprecated code issue.

@tormi
Copy link
Member Author

tormi commented Sep 30, 2022

Looks like we need to wait with the move to v8.1.

tormi added a commit that referenced this issue Jan 30, 2023
Upgrade project to Drupal 10. Resolves #313, #315.
@tormi tormi closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant