Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use of monitoring script to cromwell runs #63

Open
malachig opened this issue Aug 9, 2022 · 3 comments
Open

Add use of monitoring script to cromwell runs #63

malachig opened this issue Aug 9, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@malachig
Copy link
Member

malachig commented Aug 9, 2022

The Google Cromwell support allows for use of a "monitoring_script"

https://cromwell.readthedocs.io/en/stable/backends/Google/

{
  "monitoring_script": "gs://cromwell/monitoring/script.sh"
}

"The output of this script will be written to a monitoring.log file that will be available in the call gcs bucket when the call completes. "

This sounds very helpful. But what would such a monitoring script look like? I have not been able to find any example of someone using this functionality.

@malachig malachig added the enhancement New feature or request label Aug 9, 2022
@tmooney
Copy link
Member

tmooney commented Aug 31, 2022

https://github.com/broadinstitute/cromwell-task-monitor-bq looks to be a drop-in monitor for workflows that pushes the data to BigQuery. (In the README they estimate this monitor will add ~2% to the cost of a run.) Digging a bit more, it looks like the internals of this could possibly also be used as the monitoring_script to skip the BigQuery part.

In typical Cromwell fashion it "assumes certain defaults for naming of dataset/tables, and measurement/reporting intervals" so it ought to be fairly straightforward to plug in as long as we want to use it the same way they do!

@tmooney
Copy link
Member

tmooney commented Sep 1, 2022

I'll have to take that "skip the BigQuery part" back. I went to try it out on a tiny workflow this morning; even though there is a separate monitor directory it has BQ stuff baked into it, too.

@Layth17
Copy link
Member

Layth17 commented Nov 10, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants