Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLS] No audio with .aac #686

Closed
matthuisman opened this issue May 16, 2021 · 7 comments
Closed

[HLS] No audio with .aac #686

matthuisman opened this issue May 16, 2021 · 7 comments
Labels
Component: Audio Component: HLS Issue Type: Bug issue has reported a bug Resolution: Fixed issue was resolved by a code change

Comments

@matthuisman
Copy link
Contributor

matthuisman commented May 16, 2021

Below stream will play with video and subtitles but no audio.
Kodi shows 0 channels aac.

Master manifest: http://cdn.theoplayer.com/video/elephants-dream/playlist-single-audio.m3u8
Audio manifest: http://cdn.theoplayer.com/video/elephants-dream/en/chunklist_w370587926_b160000_ao_slen_t64RW5nbGlzaA==.m3u8
Video manifest: http://cdn.theoplayer.com/video/elephants-dream/1280/chunklist_w370587926_b2962000_vo_slen_t64TWFpbg==.m3u8
Test strm file: https://raw.githubusercontent.com/matthuisman/ia_tests/master/hls_subtitles/hls_subtitles.strm

kodi.log.txt

it only ever downloads the first aac segment.

ignore the /VIDEO_TS.IFO stuff.
Thats a bug in 19.1 that I have a PR fix for here: xbmc/xbmc#19776

@matthuisman matthuisman changed the title [HLS] No audio with .aac (VIDEO_TS.IFO??) [HLS] No audio with .aac May 24, 2021
@glennguy glennguy added the Issue Type: Bug issue has reported a bug label Jul 18, 2021
@glennguy
Copy link
Contributor

Hey I've had a quick look at this last night. The pts/offset values for the audio stream are being set to some astronomical value on stream start. My guess what happens then is the reader wants to find the right (0) pts value but as far as it can see it doesn't exist, so no way to seek to it. I opened in the debugger and set pts for the ADTS reader to 0 and stream then plays with audio.

Need to investigate further

@glennguy
Copy link
Contributor

Do you have any other streams to test with aac audio? I think I have a fix.

@matthuisman
Copy link
Contributor Author

matthuisman commented Oct 19, 2021

Yes, found one!
https://storage.googleapis.com/shaka-demo-assets/apple-advanced-stream-ts/master.m3u8

#KODIPROP:inputstream=inputstream.adaptive
#KODIPROP:inputstreamaddon=inputstream.adaptive
#KODIPROP:inputstream.adaptive.manifest_type=hls
https://storage.googleapis.com/shaka-demo-assets/apple-advanced-stream-ts/master.m3u8

confirmed no audio on above either

@glennguy
Copy link
Contributor

This one doesn't play for a different reason :) there's always something!

@matthuisman
Copy link
Contributor Author

I'm sorry 😔

@glennguy
Copy link
Contributor

glennguy commented Nov 5, 2021

I've been testing again on the elephant stream and found my fix was not good (seeking around causes lots of problems). Also, if you resume the stream the audio works fine with code as-is. I wish I knew more about ADTS...

@CastagnaIT
Copy link
Collaborator

fixed by #1241

instead for the other problematic sample
https://storage.googleapis.com/shaka-demo-assets/apple-advanced-stream-ts/master.m3u8
i copied it to the appropriate issue #1085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Audio Component: HLS Issue Type: Bug issue has reported a bug Resolution: Fixed issue was resolved by a code change
Projects
None yet
Development

No branches or pull requests

3 participants