Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamps to confirmed and spent block columns #38

Open
BrandtH22 opened this issue Oct 18, 2024 · 2 comments
Open

Add timestamps to confirmed and spent block columns #38

BrandtH22 opened this issue Oct 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@BrandtH22
Copy link
Collaborator

The wallet currently displays the confirmed and/or spent block height for coins/tokens, it would be much more user friendly to instead display the timestamp of the transaction block and have the block height (and potentially transaction ID) in a tooltip for the coin/token

@Rigidity
Copy link
Collaborator

Rigidity commented Oct 18, 2024

Good point, the wallet protocol doesn't provide this timestamp data though, so I'm not sure what the best way to get it would be.

@Rigidity Rigidity added this to the 0.8.2 milestone Nov 24, 2024
@Rigidity Rigidity added the enhancement New feature or request label Nov 24, 2024
@Rigidity
Copy link
Collaborator

Rigidity commented Nov 24, 2024

The wallet protocol doesn't have a message for this, but it turns out the peer protocol does (and this can be called by wallets too). You can request the block header for the spent and confirmed heights and get the timestamp out of the foliage block info. I'll make a queue to request all of the block timestamps for the coin records in the wallet.

@Rigidity Rigidity removed this from the 0.8.2 milestone Dec 18, 2024
@Rigidity Rigidity removed the status in Sage Wallet Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants