Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interpreter: fix incorrect values returned by arith ops when operating on fixed-width operands #3855

Open
superlopuh opened this issue Feb 6, 2025 · 1 comment
Open

interpreter: fix incorrect values returned by arith ops when operating on fixed-width operands #3855

superlopuh opened this issue Feb 6, 2025 · 1 comment
Labels
bug Something isn't working interpreter xDSL Interpreter

Comments

@superlopuh
Copy link
Member

We currently do arbitrary-bitwidth arithmetic in our interpreter, but we should be able to model exactly the arithmetic that would be executed when compiling the code, such as fixed-bitwidth integers and floats.
@superlopuh
Copy link
Member Author

This was given as feedback in one of our workshops, it was confusing that the interpreter behaviour did not correspond to the behaviour of the compiled code, as it didn't do arithmetic modulo 2 ** 32

@superlopuh superlopuh changed the title interpreter: use actual bitwidth of integers in interpreter interpreter: fix incorrect values returned by arith ops when operating on fixed-width operands Feb 13, 2025
@superlopuh superlopuh added bug Something isn't working interpreter xDSL Interpreter labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working interpreter xDSL Interpreter
Projects
Marimo Notebook Guides
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@superlopuh