Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not found: Error: Can't resolve 'asciify-image' #786

Open
NeluQi opened this issue Dec 9, 2021 · 7 comments
Open

Module not found: Error: Can't resolve 'asciify-image' #786

NeluQi opened this issue Dec 9, 2021 · 7 comments

Comments

@NeluQi
Copy link

NeluQi commented Dec 9, 2021

"@xeokit/xeokit-sdk": "^2.2.0"

WARNING Compiled with 2 warnings 06:24:26
warning in ./node_modules/@xeokit/xeokit-sdk/dist/xeokit-sdk.min.es.js

Critical dependency: the request of a dependency is an expression

warning in ./node_modules/@xeokit/xeokit-sdk/dist/xeokit-sdk.min.es.js

Module not found: Error: Can't resolve 'asciify-image' in '\node_modules@xeokit\xeokit-sdk\dist'

image

vsc writes this error to the console in the vue3 project

@WichiL
Copy link

WichiL commented Dec 9, 2021

same problem but in react project
image

@ghost
Copy link

ghost commented Dec 21, 2021

same problem in a react project

@georgy-alarcon
Copy link

Same problem in angular project also with version 2.1.0.
In my case if i rollback to version 1.9.0 this problem isn't present.

@xeolabs xeolabs closed this as completed Jun 23, 2022
@KuNman
Copy link

KuNman commented Aug 11, 2022

Why did you mark it as completed when error still occur?

@xeolabs xeolabs reopened this Aug 11, 2022
@xeolabs
Copy link
Member

xeolabs commented Aug 11, 2022

Some info for anyone willing to contribute a fix: This is not a bug in xeokit code, and seems to be introduced by one of the loaders.gl libraries, which are used by various xeokit loader plugins. There may be a rollup configuration that can work around this.

@mvalero
Copy link

mvalero commented Aug 16, 2022

Same problem here in a Vue3 Project. I solved that downgrading until hitting v2.0.0. Whenever I get any version higher than that it starts throwing the warning.

@xeolabs Can you give us some more details on your comment so we maybe can arise that bug on the loaders.gl project?

@xeolabs
Copy link
Member

xeolabs commented Aug 16, 2022

@mvalero I just did a text search for "ascify-image" within the xeokit-sdk ./src and ./node_modules found it in the loaders.gl core library.

I suspect it's either a loaders.gl compatibility with React and Vue, or some modification is needed to xeokit's Rollup/Babel configuration.

I'd recommend reproducing the issue somehow in a trivial dummy-project that just uses loaders.gl, maybe copying relevant configs from xeokit's Rollup/Babel configs etc. Then that would determine if it's some sort of CJS build issue or React/View incompatibility within loaders.gl. Then that would reproduce the bug for logging the issue (if existing) for loaders.gl.

Before doing that though, I'd also recommend looking first to see if loaders.gl has any caveats or tips on Vue/React integrations. Maybe also look around for any React/Vue apps build on loaders.gl, see if they do things different in their build scripts etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants