Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty levels should breaks latches #613

Closed
wismill opened this issue Jan 24, 2025 · 0 comments · Fixed by #618
Closed

Empty levels should breaks latches #613

wismill opened this issue Jan 24, 2025 · 0 comments · Fixed by #618
Labels
bug Indicates an unexpected problem or unintended behavior state Indicates a need for improvements or additions to the xkb_state API
Milestone

Comments

@wismill
Copy link
Member

wismill commented Jan 24, 2025

Testing the German E1 with its modifiers changed as Latches, I found that empty levels do not break latches. Indeed, we skip our for loops in filters because the count is zero! 😅 This is a regression introduced in #487.

Why break latches with empty levels? In essence they are levels with just a NoSymbol keysym, and NoAction breaks latches.


Discovered indirectly thanks to @Jules-Bertholet who mentioned the E1 layout.

@wismill wismill added bug Indicates an unexpected problem or unintended behavior state Indicates a need for improvements or additions to the xkb_state API labels Jan 24, 2025
@wismill wismill added this to the 1.8.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior state Indicates a need for improvements or additions to the xkb_state API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant