Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure pre-commit and Ruff #16

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lucabenvenuto
Copy link
Contributor

Type of change

  • Fix
  • Story
  • Chore

Description of the change

  • Set up and configure pre-commit
  • Create pyproject.toml containing configuration for ruff and mypy
  • Set up ruff hooks for pre-commit
  • Set up mypy hook for pre-commit using existing script

Related PRs

N/A

@lucabenvenuto lucabenvenuto requested a review from pgrill July 30, 2024 16:35
This was linked to issues Jul 30, 2024
@lucabenvenuto lucabenvenuto force-pushed the feat/add-ruff-precommit branch from 19e5fa3 to a5cd2cb Compare July 30, 2024 17:15
Copy link
Collaborator

@pgrill pgrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Luca. I want to manually test the changes before Approve the PR. I will test it tomorrow.

@@ -0,0 +1,27 @@
# See https://pre-commit.com/hooks.html for more hooks
repos:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can include the default_stages option for execute the linter only the push.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include precommit Use Ruff linter and formatter
3 participants