Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing information about the p:os-exec cwd option #655

Closed
xatapult opened this issue Jan 8, 2025 · 2 comments · Fixed by #662
Closed

Missing information about the p:os-exec cwd option #655

xatapult opened this issue Jan 8, 2025 · 2 comments · Fixed by #662

Comments

@xatapult
Copy link
Contributor

xatapult commented Jan 8, 2025

The cwd option of p:os-exec specifies the current working directory. The description leaves unspecified what this is: a URI? a OS dependent string? I think we must specify this (or at least say its implementation or OS defined).

Morgana currently (on Windows) only accepts a non-URI path, like C:/x/y/z. Making it a URI (file:/ in front) results in an error.

@ndw
Copy link
Collaborator

ndw commented Jan 8, 2025

I'd be happy to make it a URI. My implementation also treats it as a OS-specific string at the moment, except for a little path-separator mangling.

@ndw
Copy link
Collaborator

ndw commented Jan 31, 2025

Gerrit suggests that we document that the input is passed through p:urify() to handle the Windows/Mac/Linux/cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants