Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show app version in "footer" #157

Open
xy2z opened this issue Dec 3, 2019 · 1 comment
Open

Show app version in "footer" #157

xy2z opened this issue Dec 3, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@xy2z
Copy link
Owner

xy2z commented Dec 3, 2019

When the Docker image is built, it should get the current git tag as an env variable, so in the code we can show what the current version is.

This probably means the Dockerfile should install git, get the latest/current tag, and uninstall/purge git after that.

I was hoping Docker would set this env automatically, but apparently it doesn't.

"footer" means below "sign out" link in the left sidebar.
Maybe also show it in the login/register/forgot-password pages in the footer.

@xy2z xy2z added the enhancement New feature or request label Dec 3, 2019
@xy2z xy2z added this to the v1.0 milestone Dec 3, 2019
@xy2z
Copy link
Owner Author

xy2z commented Dec 28, 2019

This wasn't as easy as I thought...

Docker Hub can't run git commands on build, because it's not a git repository... So I can't do it on the Dockerfile or the entrypoint file. And I don't want to build and push the manually.

I'm waiting till this can be done automated from the git tag (git describe --tags), since I don't want to manually tag every release, and I'll most likely forget.

@xy2z xy2z removed this from the v1.0 milestone Dec 28, 2019
xy2z added a commit that referenced this issue Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant