Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo & Redo bugs when changing notes (History) #63

Closed
xy2z opened this issue May 26, 2019 · 2 comments
Closed

Undo & Redo bugs when changing notes (History) #63

xy2z opened this issue May 26, 2019 · 2 comments
Labels
bug Something isn't working ui
Milestone
v1.0

Comments

@xy2z
Copy link
Owner

xy2z commented May 26, 2019 •
edited
Loading

It uses history for the other notes...
So maybe a new editor instance per note?

Reproduce

  1. Enable History in tiptap (resources/js/components/EditorContent.vue file)
  2. run npm run dev (or npm run watch)
  3. Login on Dopenote
  4. Edit note content
  5. Change note
  6. Press CTRL+Z
    and content changes to the previos note content.

History should be per note. I'm not sure what a good solution to this bug is, so for now I've disabled history...
@xy2z xy2z added this to the v1.0 milestone May 26, 2019
@xy2z xy2z added the bug Something isn't working label Aug 7, 2019
@xy2z xy2z added the ui label Sep 8, 2019
@xy2z xy2z changed the title Undo & Redo bugs when changing notes Undo & Redo bugs when changing notes (History) Sep 15, 2019
@xy2z xy2z added the hacktoberfest Hacktoberfest 2019 label Oct 7, 2019
@xy2z xy2z pinned this issue Oct 10, 2019
@xy2z xy2z removed the hacktoberfest Hacktoberfest 2019 label Nov 22, 2019
xy2z added a commit that referenced this issue Mar 4, 2020
@xy2z
#63 Implemented undo/redo for notes
1cba464
@xy2z
Copy link
Owner Author

xy2z commented Mar 4, 2020

Implemented custom undo/redo functionality.
This will have to be tested alot before release

xy2z added a commit that referenced this issue Mar 6, 2020
@xy2z
#63 Fixed undo/redo to work with CAPS enabled, and CTRL/CMD+SHIFT+Z f…
86003a5 
…or redo
@xy2z
Copy link
Owner Author

xy2z commented Mar 14, 2020 •
edited
Loading

Seems to work for now.
However, this (probably) needs to be changed before moving to sockets because it probably won't work with multiple users at the same time. Prosemirrors build in history should take care of that.
So I've made a feature request for a clear/reset history method in prosemirror.

Closing this as it seems to work all right for v1.0

@xy2z xy2z closed this as completed Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@xy2z