Skip to content

Overly complicated @Config usage in Dynamic Darkness (Fix included) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rongmario opened this issue Sep 12, 2021 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@Rongmario
Copy link

Here's a way to use @Config even if your mod is a coremod/mixin.

@democat3457
Copy link

democat3457 commented Sep 13, 2021

Unrelated but

loli

👀

@tie
Copy link
Member

tie commented Sep 13, 2021

Yeah, it’s a rather dirty hack indeed. Thanks for giving a good reference that uses public API!

I wanted to keep the config GUI when I’ve dropped dependency on mixin. The current implementation is, uh, a temporary workaround since both config I/O and GUI require a decent amount of boilerplate, and @Config transparently handles both.

@tie tie added the enhancement New feature or request label Sep 13, 2021
@Rongmario
Copy link
Author

Yeah that's fair. I only opened this thread bc someone was getting a crash using this mod and my LoliASM, which optimizes some strings in the background.

Unrelated but

loli

👀

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants