From e72e1a0be27608d10ab02fdf4308dac70d5ba3cf Mon Sep 17 00:00:00 2001 From: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> Date: Thu, 14 Dec 2023 23:28:58 +0900 Subject: [PATCH] fix: improve Ruby release workflow - Remove redundant `git push` - Combine jobs for creating a GitHub release --- .github/workflows/ruby-release-reusable.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ruby-release-reusable.yml b/.github/workflows/ruby-release-reusable.yml index 04fab53..89d3b26 100644 --- a/.github/workflows/ruby-release-reusable.yml +++ b/.github/workflows/ruby-release-reusable.yml @@ -35,16 +35,14 @@ jobs: run: | git config --global user.name "${GITHUB_ACTOR}" git config --global user.email "${GITHUB_ACTOR}@users.noreply.github.com" - - name: Publish to gem registry + - name: Release gem run: bundle exec rake release env: GEM_HOST_API_KEY: ${{ secrets.api-key }} GEM_HOST_OTP_CODE: ${{ inputs.otp }} - - name: Push tag - run: git push --follow-tags - - name: Get tag - run: echo "TAG_NAME=$(git describe --abbrev=0)" >> "${GITHUB_ENV}" - name: Create GitHub release - run: gh release create "${TAG_NAME}" --draft + run: | + tag_name="$(git describe --tags --abbrev=0)" + gh release create "${tag_name}" --verify-tag --draft env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}