Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet Component Styling Issues #623

Open
benmcginnis opened this issue Apr 1, 2020 · 1 comment
Open

Facet Component Styling Issues #623

benmcginnis opened this issue Apr 1, 2020 · 1 comment

Comments

@benmcginnis
Copy link
Member

Checkbox & chevron baseline alignment is high by ~ 2px:

Screen Shot 2020-03-31 at 7 58 32 PM

Additionally, the facet component should probably not restrict it's presentation (by setting a width on itself) since it could be used in isolation in a custom layout.

For example this treatment:
Screen Shot 2020-03-31 at 8 00 20 PM

Would be very difficult to accomplish with the component as it exists today.

@benmcginnis
Copy link
Member Author

Recommendations from design/qa:

.yxt-FilterOptions-option
{
  align-items: center;
  line-height: 1.6;
}

.yxt-FilterBox-titleContainer [data-component="IconComponent"]
{
  line-height: 0; // might want to do this on the IconComponent itself
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant