Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

Auto-generating edward config misses a project #104

Open
bsravanin opened this issue May 5, 2017 · 1 comment
Open

Auto-generating edward config misses a project #104

bsravanin opened this issue May 5, 2017 · 1 comment
Labels
Milestone

Comments

@bsravanin
Copy link

On running edward generate ComparativeReviewsServer after updating the corresponding build.spec, it

  • did not recognize ComparativeReviewsServer at all, and instead
  • added a few imports (edward.json, a number of gocode/src/github.com/yext/edward/examples/[dir]/edward.json files, and a couple of gocode/src/github.com/yext/edward/generators/testdata/edward/[dir]/[dir]/edward.json files)
  • increased the indentation for few of the blocks already in edward.json

Edward version 1.7.2

@theothertomelliott
Copy link
Contributor

theothertomelliott commented Aug 31, 2017

  • The added imports is because it's picking up the checked out copy of edward. Should be able to fix that by adding edwardignore to the relevant folders.
  • The indentation is a result of some people manually adding config and not formatting it. This can be ignored for now (this may actually be desirable).

Adding a story for the imports, and this one can focus on ComparativeReviewsServer.

@theothertomelliott theothertomelliott changed the title Error auto-generating edward config Auto-generating edward config misses a project Aug 31, 2017
@theothertomelliott theothertomelliott modified the milestones: 1.9, 1.8.4 Aug 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants