Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https tracker url not supported #41

Open
DJPlaya opened this issue Dec 23, 2019 · 12 comments
Open

https tracker url not supported #41

DJPlaya opened this issue Dec 23, 2019 · 12 comments
Assignees

Comments

@DJPlaya
Copy link

DJPlaya commented Dec 23, 2019

This is a Problem i do get when using recent Torrents on privat Trackers.
Info:

https://i.imgur.com/o56uof8.png

@ygrek
Copy link
Owner

ygrek commented Feb 10, 2020

please include text version, I am not going to transcribe hashes from screenshot

@ygrek
Copy link
Owner

ygrek commented Feb 10, 2020

apparently mldonkey does not support https tracker urls

@ygrek ygrek changed the title error: Tracker type not supported https tracker url not supported Feb 10, 2020
@J-Siu
Copy link

J-Siu commented May 23, 2020

I believe not only tracker, but https torrent links are also affected. I tried following:

https://releases.ubuntu.com/20.04/ubuntu-20.04-live-server-amd64.iso.torrent

mldonkey seems not able to fetch the torrent file.

@ygrek ygrek self-assigned this May 24, 2020
@HinTak
Copy link
Contributor

HinTak commented Jul 3, 2021

Any progress on this? It certainly looks like many ISPs are implementing filtering of bittorrent traffic, regardless of / even for obviously legitimate usage like large Linux distro isos.

@ygrek
Copy link
Owner

ygrek commented Jul 4, 2021

I would think the best way to solve it is to use ocurl library but I don't have immediate plan to work on it

@carlonluca
Copy link
Contributor

@ygrek if I wanted to use ocurl to support HTTPS, how would you suggest to do it in mldonkey? I see that ocurl includes sync calls. But mldonkey download is async. I thought I could use threads, but I see that mldonkey does not use threads. In ocurl I see there is the multi module, is that what you would use?
Thanks.

@ygrek
Copy link
Owner

ygrek commented Jan 11, 2025

Long term should switch to lwt but there is a lot of networking code so it is not possible to switch quickly.
I think best short-term would be to use a pool of threads for ocurl synchronous calls.

@carlonluca
Copy link
Contributor

carlonluca commented Jan 11, 2025

I thought about that, but in that case the callback would be called in the new thread. I have no experience with ocaml, but I read this:

Only one thread at a time is allowed to run OCaml code on a particular domain ‍9.5.1.

So I'm not entirely sure this is a problem. What do you think? Should I somehow call the callback in the thread of the caller? Can I do that somehow?
Thanks for your answer.

@ygrek
Copy link
Owner

ygrek commented Jan 12, 2025

this is fine, no need to do anything special, one thread at a time actually makes it easier because no need to worry about mutexes or anything :)

@carlonluca
Copy link
Contributor

Hello @ygrek,
while working on this I met a problem. Could you please have a look at #125?

@carlonluca
Copy link
Contributor

Hello @ygrek ,
found another small issue while working on this: #126. Could you please have a look?

@carlonluca
Copy link
Contributor

For those interested, I uploaded a few patches to a branch in my mldonkey fork that should add support for https, https trackers and for downloading torrent files: https://github.com/carlonluca/mldonkey/commits/feature/curl/.

Unfortunately, torrents still do not seem to start for me. If there is someone else who wants to try, please let me know the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants