-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https tracker url not supported #41
Comments
please include text version, I am not going to transcribe hashes from screenshot |
apparently mldonkey does not support https tracker urls |
I believe not only tracker, but https torrent links are also affected. I tried following: https://releases.ubuntu.com/20.04/ubuntu-20.04-live-server-amd64.iso.torrent mldonkey seems not able to fetch the torrent file. |
Any progress on this? It certainly looks like many ISPs are implementing filtering of bittorrent traffic, regardless of / even for obviously legitimate usage like large Linux distro isos. |
I would think the best way to solve it is to use ocurl library but I don't have immediate plan to work on it |
@ygrek if I wanted to use ocurl to support HTTPS, how would you suggest to do it in mldonkey? I see that ocurl includes sync calls. But mldonkey download is async. I thought I could use threads, but I see that mldonkey does not use threads. In ocurl I see there is the multi module, is that what you would use? |
Long term should switch to lwt but there is a lot of networking code so it is not possible to switch quickly. |
I thought about that, but in that case the callback would be called in the new thread. I have no experience with ocaml, but I read this:
So I'm not entirely sure this is a problem. What do you think? Should I somehow call the callback in the thread of the caller? Can I do that somehow? |
this is fine, no need to do anything special, one thread at a time actually makes it easier because no need to worry about mutexes or anything :) |
For those interested, I uploaded a few patches to a branch in my mldonkey fork that should add support for https, https trackers and for downloading torrent files: https://github.com/carlonluca/mldonkey/commits/feature/curl/. Unfortunately, torrents still do not seem to start for me. If there is someone else who wants to try, please let me know the result. |
This is a Problem i do get when using recent Torrents on privat Trackers.
Info:
The text was updated successfully, but these errors were encountered: