Feat: follow link prefixed with file:// in the string content using documentLinkProvider #27
Conversation
|
@deribaucourt |
WilsonZiweiWang
changed the title
client/src/documentLinkProvider.ts
Outdated
| link.range.end.character | ||
| ) | ||
| try { | ||
| const [file] = await vscode.workspace.findFiles(link.value, undefined, 1) |
There was a problem hiding this comment.
This gets called non stop and saturates all my CPUs to 100% for too long untill all links are generated. Make sure it's only called only when a "cltr+click" event is generated or the least amount of time possible. (opening busybox_*.bb)
There was a problem hiding this comment.
Also after I click a first time, it takes forever for the links to work again.
There was a problem hiding this comment.
Or maybe it's just a performance issue in the for loops.
There was a problem hiding this comment.
Your fix is very good.
There was a problem hiding this comment.
There still was a performance issue in your latest branch. I pushed a commit that greatly reduces the CPU consumption when opening recipes with many defined file:// links.
WilsonZiweiWang
force-pushed
the
Feature-10430-go-to-definition-for-SRC-URI-documentLinks
branch
from
b63bf68 to
88f077a
Compare
…re storing the symbols as they are only needed occasionally
Running findFiles() creates a ripgrep process for each URL which could saturate the CPU for tens of seconds. This patch optimizes the findRelatedFiles() function to only run findFiles() once and then filter the results.
deribaucourt
force-pushed
the
Feature-10430-go-to-definition-for-SRC-URI-documentLinks
branch
from
82346e0 to
670bac7
Compare
deribaucourt
deleted the
Feature-10430-go-to-definition-for-SRC-URI-documentLinks
branch
Use the
documentLinkProviderto provide the correct links in the string content.