Fix: Handle dialog promise rejection #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In integration tests in CI, the dialog promise is rejected at random time events. try/catch does not catch the error, it must actually be handled in the promise rejection handler.
The tricky dirname util doesn't give the parent directory when the
argument is the current directory ('.'). This resulted in infinite
loops if the current directory happened to be scanned.
Could happen with partially incorrect configurations.
The default timeout of 2s might not be enough to delete the build directories with bitabke parsing caches. I used a longer one for the commandWrapper tests because it updates the configurations which has to wait for three promises.
idillon-sfl
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In integration tests in CI, the dialog promise is rejected at random time events. try/catch does not catch the error, it must actually be handled in the promise rejection handler.