Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When error happens, db password information is shown #220

Closed
pinkfrog9 opened this issue Jul 28, 2022 · 5 comments
Closed

When error happens, db password information is shown #220

pinkfrog9 opened this issue Jul 28, 2022 · 5 comments
Labels
enhancement help wanted

Comments

@pinkfrog9
Copy link
Contributor

This piece of information should better be hidden.
@yogthos
Copy link
Owner

yogthos commented Jul 28, 2022

Agreed, this would be good to omit in the log. Would you be up for making a PR for this by any chance?

@pinkfrog9
Copy link
Contributor Author

Hi @yogthos. Would you please look at: #222

@yogthos
Copy link
Owner

yogthos commented Jul 29, 2022

Thanks looks good, there are a few other fixes in the works, so I'll cut a new release next week.

@ieugen
Copy link
Collaborator

ieugen commented Jul 31, 2022

Relates to #189 .
Possible duplicate.

@ieugen
Copy link
Collaborator

ieugen commented Jul 31, 2022 •
edited
Loading

This was released as part of 1.4.0. Thanks @pinkfrog9 !

@ieugen ieugen closed this as completed Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yogthos @ieugen @pinkfrog9