fix: linting

Author: Mollemoll

lib/valvat/checksum/ch.rb

@@ -6,7 +6,7 @@ class CH < Base
       # All CH VAT starts with CHE. First figure is a character and should be skipped.
       # The CH VATs can have a suffix (MWST, TVA, IVA) which should be skipped.
       # Thus giving 8 figures to calculate the check digit
-      FIGURES_RANGE = [1..8]
+      FIGURES_RANGE = [1..8].freeze
       CHECK_DIGIT_POS = 9
 
       def check_digit

lib/valvat/lookup/bfs.rb

@@ -35,7 +35,7 @@ class BFS < Base
       def self.prepare_for_lookup(vat)
         # BFS requires a space between the VAT number and the suffix (if present)
         index_of_suffix = vat =~ /MWST|IVA|TVA/
-        return if !index_of_suffix
+        return unless index_of_suffix
 
         vat.insert(index_of_suffix, ' ')
       end
@@ -90,18 +90,17 @@ def convert_values(hash)
         return build_fault(hash) if hash[:faultstring]
 
         is_valid = case hash[:validate_vat_number_result]
-                        when 'true' then true
-                        when 'false' then false
-                        else nil
-                       end
+                   when 'true' then true
+                   when 'false' then false
+                   end
 
         { valid: is_valid }
       end
 
       FAULTS = {
         'securityFaultFault' => SecurityError,
         'businessFaultFault' => BusinessError,
-        'infrastructureFaultFault' => InfrastructureError,
+        'infrastructureFaultFault' => InfrastructureError
       }.freeze
 
       def build_fault(hash)

spec/valvat/checksum/ch_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 
 describe Valvat::Checksum::CH do
-    ["CHE-343.663.860", "CHE343663860", "CHE-355.036.078", "CHE355036078", "CHE-480.519.647", "	CHE480519647"].each do |valid_vat|
+  ['CHE-343.663.860', 'CHE343663860', 'CHE-355.036.078', 'CHE355036078', 'CHE-480.519.647',
+   "\tCHE480519647"].each do |valid_vat|
     it "returns true on valid VAT #{valid_vat}" do
       expect(Valvat::Checksum.validate(valid_vat)).to be(true)
     end

spec/valvat/lookup/bfs_spec.rb

@@ -12,10 +12,10 @@
   it 'returns hash that includes valid: false on invalid input' do
     response = described_class.new('CHE-343.663.86MWST', ch: true).perform
     expect(response).to match({
-                                :detail=>nil,
-                                :faultcode=>"s:Client",
-                                :faultstring=>"Data_validation_failed",
-                                :valid=>false,
+                                detail: nil,
+                                faultcode: 's:Client',
+                                faultstring: 'Data_validation_failed',
+                                valid: false
                               })
   end
 end

spec/valvat/syntax_spec.rb

@@ -21,12 +21,15 @@ def it_validates(valid_vats, invalid_vats)
     it_validates(%w[ATU03458890], %w[ATU034588908 ATU0345908 ATU0345889Y])
     it_validates(%w[BE0817331995 BE1817331999], %w[BE081733199 BE08173319944 BE081733199H BE2817331999])
     it_validates(%w[BG468134789 BG4681347897], %w[BG46813478979 BG4681347897C BG46813478G BG46813478])
-    it_validates(["CHE-343.663.860", "CHE-343.663.860MWST", "CHE-343.663.860 MWST", "CHE343663860", "CHE343663860MWST", "CHE343663860 MWST"],
-                 ["CHE-343.663.8601", "CHE-343.663.8601MWST", "CHE-343.663.8601 MWST", "CHE-34.663.860", "CHE-34.663.860MWST", "CHE-34.663.860 MWST"])
-    it_validates(["CHE-343.663.860", "CHE-343.663.860TVA", "CHE-343.663.860 TVA", "CHE343663860", "CHE343663860TVA", "CHE343663860 TVA"],
-                 ["CHE-343.663.8601", "CHE-343.663.8601TVA", "CHE-343.663.8601 TVA", "CHE-34.663.860", "CHE-34.663.860TVA", "CHE-34.663.860 TVA"])
-    it_validates(["CHE-343.663.860", "CHE-343.663.860IVA", "CHE-343.663.860 IVA", "CHE343663860", "CHE343663860IVA", "CHE343663860 IVA"],
-                 ["CHE-343.663.8601", "CHE-343.663.8601IVA", "CHE-343.663.8601 IVA", "CHE-34.663.860", "CHE-34.663.860IVA", "CHE-34.663.860 IVA"])
+    it_validates(['CHE-343.663.860', 'CHE-343.663.860MWST', 'CHE-343.663.860 MWST', 'CHE343663860', 'CHE343663860MWST', 'CHE343663860 MWST'],
+                 ['CHE-343.663.8601', 'CHE-343.663.8601MWST', 'CHE-343.663.8601 MWST', 'CHE-34.663.860',
+                  'CHE-34.663.860MWST', 'CHE-34.663.860 MWST'])
+    it_validates(['CHE-343.663.860', 'CHE-343.663.860TVA', 'CHE-343.663.860 TVA', 'CHE343663860', 'CHE343663860TVA', 'CHE343663860 TVA'],
+                 ['CHE-343.663.8601', 'CHE-343.663.8601TVA', 'CHE-343.663.8601 TVA', 'CHE-34.663.860',
+                  'CHE-34.663.860TVA', 'CHE-34.663.860 TVA'])
+    it_validates(['CHE-343.663.860', 'CHE-343.663.860IVA', 'CHE-343.663.860 IVA', 'CHE343663860', 'CHE343663860IVA', 'CHE343663860 IVA'],
+                 ['CHE-343.663.8601', 'CHE-343.663.8601IVA', 'CHE-343.663.8601 IVA', 'CHE-34.663.860',
+                  'CHE-34.663.860IVA', 'CHE-34.663.860 IVA'])
     it_validates(%w[CY36579347A CY36579347C CY60000347C], %w[CY36579347 CY365793478 CY365793478A CY365793G])
     it_validates(%w[CZ56389267 CZ563892670 CZ5638926790], %w[CZ5638926 CZ56389268901])
     it_validates(%w[DE345889003], %w[DE34588900 DE3458890090 DE34588900C])