Valvat::Options: Added deprecated keys specs

Author: yolk

spec/valvat/lookup_spec.rb

@@ -182,23 +182,6 @@
                                 })
       end
 
-      it 'supports old :requester_vat option for backwards compatibility' do
-        result = described_class.validate('IE6388047V', requester_vat: 'LU21416127')
-
-        skip 'VIES is down' if result.nil?
-
-        expect(result).to match({
-                                  request_date: kind_of(Date),
-                                  request_identifier: /\A[\w\W]{16}\Z/,
-                                  country_code: 'IE',
-                                  vat_number: '6388047V',
-                                  name: 'GOOGLE IRELAND LIMITED',
-                                  company_type: nil,
-                                  address: '3RD FLOOR, GORDON HOUSE, BARROW STREET, DUBLIN 4',
-                                  valid: true
-                                })
-      end
-
       context 'with GB VAT number' do
         include_context 'with hmrc configuration'
 

spec/valvat/options_spec.rb

@@ -22,11 +22,28 @@
                                  )
     end
 
-    context 'when options contains deprecated key' do
-      let(:options) { described_class.new({ requester_vat: 'DE123' }, silence: true) }
+    context 'when options contains deprecated key requester_vat' do
+      it 'returns it on new key' do
+        expect(described_class.new({ requester_vat: 'DE123' }, silence: true)[:requester]).to be('DE123')
+      end
 
+      it 'prints deprecation warning' do
+        expect do
+          described_class.new({ requester_vat: 'DE123' })
+        end.to output("DEPRECATED: The option :requester_vat is deprecated. Use :requester instead.\n").to_stdout
+      end
+    end
+
+    context 'when options contains deprecated key savon' do
       it 'returns it on new key' do
-        expect(options[:requester]).to be('DE123')
+        expect(described_class.new({ savon: { somekey: :somevalue } },
+                                   silence: true)[:http]).to eq({ somekey: :somevalue })
+      end
+
+      it 'prints deprecation warning' do
+        expect do
+          described_class.new({ savon: { somekey: :somevalue } })
+        end.to output("DEPRECATED: The option :savon is deprecated. Use :http instead.\n").to_stdout
       end
     end
   end