Romanian typos and translation updates

[mireille-raad]

PPA pointed some typos, translation and mistakes. I will do a pull request and fix them... might save us a lot of back and forth

[bezunakarmi]

@DC-coder That sound great. It would be much helpful.

[mireille-raad]

I am still working on this on my forked copy.

So far here is a list of the changes and what has been done and what's pending.

I will submit pull request soon.

Feel free to share a tip how to do any of the incomplete tasks

All pages

• cāutare for all search screens
  note: I updated the main search bar, the one on click in menu. I did this except for footer, where the title is suitable.

• M Leu - > MDL

• suma -> suma contractului

• replace all Muncă with Lucrări

• Capital in first letter of all the items in menu (sentence case)

• In table, when there is dash only, see why (if DAAC is publishing this or the system is trimming it)

• For totals, summ should be standard 115,599.00 (standard, no Millions no MDL, no M etc)

• For all horizontal bar charts, wrap the text so it can be read. If necessary change proportion of text and chart

• Voloare -> valoare

Footer

• Data de reîmprospătare Ultimele date : Jun 26, 2017 -> Data de actualizare: Jun 26, 2017
• Update footer to - Despre Descărcări Contacte Ajutor Github
• subscribe -> Abonați-vă
• Distribuie page -> Distribuie pagina

Tenders

• In data table, bulletin should be with one L and in all website
  I think the data from DAAC is this way, not sure we can solve this issue... unless we want to add a way to replace the strings in import scripts.

• Column 1 should be the content of col 2

• The new column 1 should change from Tender Ref 12/00001 Bulletin 82 -> 12/00001 Buletin 82/2012 (yy)

• Column 2 should be the object of procurement (Servicii de tratament sanatorial)
  I need to check this

Contracts

• Remove " emis de-a lungul anilor" from graph

Goods

• In detailed item view in tab 4, example link1 and link2, the graphs and the numbers have different titles. Change as follow:
  numărul contractelor -> numărul total de contracte
  suma contractului -> suma totală a contractelor

• in detailed view, dropdowns saying "Based on value" and "Based on count" in english, should be in romanian (get translation from other screens)

Contractors

(/contracts/contractor)

• Title of page should start with a capital letter
• Nume -> operator economic
• remove schema or maybe replace it with 'valoarea contractului' (value of contracts)
  (I removed it, will see if it is easy to add total value)

[mireille-raad]

I am a little bit stuck... @bezunakarmi can I get some help on the following:

• For totals in tables, summ should be standard 115,599.00 (no Millions, no M letter added etc)
  I checked the raw json and the amounts are the full numbers... I tried to see where the million( M letter) is being added, couldn't find it. The only reference I could find is in phpexcel. any idea in which file i should look?

• For all horizontal bar charts, wrap the text so it can be read. If necessary change proportion of text and chart

I checked how to wrap text with d3 ...I am not sure of the code changes that needs to be done or where each bar chart is generated. (i tried to add some console.log to find location)
Here are the useful link i found
https://github.com/vijithassar/d3-textwrap
https://bl.ocks.org/mbostock/7555321
https://stackoverflow.com/questions/24784302/wrapping-text-in-d3
any idea how to implement?

I appreciate if you can tell me where to make the changes ... if you prefer to make the changes, then i will drop them from my to do list.

[bezunakarmi]

@DC-coder. We are formatting the amount field by calling the function number_format(). It is in number_format.js file which is located at https://github.com/younginnovations/opencontracting-moldova/blob/master/resources/assets/js/vendor/number-format.js.

And for the horizontal chart, we make call to createBarChartProcuring() function. This file can be found in https://github.com/younginnovations/opencontracting-moldova/blob/master/resources/assets/js/charts/custom/horizontal-barChart.js.

If you need any assistance in these issues, I'm all ready to help. If you find it complex then assign me to these issues.

[mireille-raad]

thanks! I am on it... I figured out the number formatting, still have the wrapping of text.

I should be submitting a pull request soon, I'll be grateful if you can review and merge/publish to the official site!

Thanks a ton!

[bezunakarmi]

That sounds great.

Let us know if you have any confusion regarding the code, we are happy to provide our assistance.

[mireille-raad]

done :) feel free to edit my pull request. Let me know if any code edits look ugly and you rather i improve before merging.

Let me know if you need clarification on why some edits happened.

Once the changes are reflected on opencontracting.date.gov.md - I will send email to PPA and colleagues to confirm that all is done.

[bezunakarmi]

Thank you for your contribution to the code, much appreciated.

Translations that you have changed to the portal are perfect. But the placeholder text for the search (anywhere in the portal) was better before than just "Search", which has changed now.

And I see that you have removed code having "number_format()" from most of the pages. This has some effects in the portal where numbers(amount) are not formatted. For eg: in home page

, in contract's detail page and most of the data tables.

Is it ok if I make required changes to the codes? Let me know if I'm ready to go.

[mireille-raad]

Thanks for flagging that the sum on homepage looks weird.

I undid the number format next to the search bar on the homepage. I will leave the others as is because I think they were having problems with sorting the data table.

I agree with you that some of the placeholder for the search screens were nicer... But I will do as per feedback and try to re-discuss with them.

Please let me know if you can merge and publish the code changes. Then I will send a long email to PPA about our edits and some questions for DAAC and hopefully this will be our last iteration.

[bezunakarmi]

I'm ok with all other changes that you have made but the number format in the data table is an issue. I tested by making changes, there wasn't any problem in data table while sorting. Could you make the changes?

Hopefully, then it will be ready to merge. I'm happy to assist in improving your merge request.

[mireille-raad]

Can you do the merge and exclude my changes to number format in the table? do you want me to submit another commit?

Once the site is updated, I will email PPA and try to see if they are ok with the numbers as is.
The ladies I worked with said they want the number formatted as regular in the table. I had tried to insist before, but will try again.

What is the exact issue with the number format in the table btw?

[mireille-raad]

oh and thank you for your patience on this

[bezunakarmi]

I have merged your changes into master. Also, I have made changes to the number format issue.
I have deployed changes to both demo and production server. Please do review it. Feel free to contact if there are any queries.

[bezunakarmi]

@DC-coder any feedback from PPA on this?