Tribblix build error: no dprintf

[schmonz]

With "1.7" (at commit `329110310c71a08a942b4a36613b6db090df65f4``) on Tribblix m25:

gcc -O2 -D_FORTIFY_SOURCE=2 -I/opt/pkg/include -I/usr/include -std=c99 -pedantic -Wall -Wextra -D_XOPEN_SOURCE=700 -D_BSD_SOURCE -I/opt/pkg/include -I/usr/include  -c -o httppc.o httppc.c
httppc.c: In function 'main':
httppc.c:67:2: warning: implicit declaration of function 'dprintf'; did you mean 'vprintf'? [-Wimplicit-function-declaration]
  dprintf(WRITE_FD, "CONNECT %s:%s HTTP/1.1\r\n", host, port);
  ^~~~~~~
  vprintf
gcc -O2 -D_FORTIFY_SOURCE=2 -I/opt/pkg/include -I/usr/include -std=c99 -pedantic -Wall -Wextra -D_XOPEN_SOURCE=700 -D_BSD_SOURCE -I/opt/pkg/include -I/usr/include  -c -o http_parser.o http_parser.c
gcc -L/opt/pkg/gcc7/lib/gcc/x86_64-sun-solaris2.11/7.5.0 -Wl,-R/opt/pkg/gcc7/lib/gcc/x86_64-sun-solaris2.11/7.5.0 -L/opt/pkg/lib -Wl,-R/opt/pkg/lib -L/usr/lib/amd64 -Wl,-R/usr/lib/amd64 -o httppc httppc.o http_parser.o
Undefined                       first referenced
 symbol                             in file
dprintf                             httppc.o
ld: fatal: symbol referencing errors. No output written to httppc
collect2: error: ld returned 1 exit status

Not sure whether you'd prefer to include a fallback definition for dprintf(), or avoid its use, or decide this isn't worth fixing. (FWIW, I'm eager to take advantage of these tools as soon as they're building and running well on the platforms where I'd use them.)

[younix]

Which libc do you use?

[schmonz]

I don’t know! Tribblix is an Illumos so I guess it’s ultimately Solaris-derived.

[schmonz]

Happy to provide SSH access to a Tribblix VM, if that'd help.

[younix]

I implemented a dprintf() version in httppc.
Can you test this, on you plattform and give me some feedback?

Thanks!

[schmonz]

It gets httppc building. (httpc needs the same.) What would be a good way to test?

[younix]

Also, Implemented for httpc. Now, you can use httppc and httpc in a row for testing.

Thanks for you help, to improve this tools.

[schmonz]

I haven't used these tools yet. Should make test be a sufficient exercise? If so, I'll focus on getting the tests running. If not, an example command line would be handy.

[schmonz]

I'm seeing make test hang here, on several non-OpenBSD platforms:

1..32
ok 1 - plain connection server -> client
ok 2 - environment variable: "^TCPREMOTEIP=127.0.0.1$"
ok 3 - environment variable: "^TCPREMOTEHOST=localhost$"
ok 4 - environment variable: "^TCPREMOTEPORT=47258$"
ok 5 - environment variable: "^TCPLOCALIP=127.0.0.1$"
ok 6 - environment variable: "^TCPLOCALHOST=localhost$"
ok 7 - environment variable: "^TCPLOCALPORT=60013$"
ok 8 - environment variable: "^PROTO=TCP$"
ok 9 - plain connection client -> server
ok 10 - environment variable: "^TCPREMOTEIP=127.0.0.1$"
ok 11 - environment variable: "^TCPREMOTEHOST=localhost$"
ok 12 - environment variable: "^TCPREMOTEPORT=55035$"
ok 13 - environment variable: "^TCPLOCALIP=127.0.0.1$"
ok 14 - environment variable: "^TCPLOCALHOST=localhost$"
ok 15 - environment variable: "^TCPLOCALPORT=45014$"
ok 16 - environment variable: "^PROTO=TCP$"

I'm linking with libretls and running the tests under @ibara's portable oksh. Is this a combination we expect and/or want to work? How can I provide more details?