Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] PgClientSession\PgClientService code cleanup #25652

Open
1 task done
d-uspenskiy opened this issue Jan 16, 2025 · 0 comments
Open
1 task done

[YSQL] PgClientSession\PgClientService code cleanup #25652

d-uspenskiy opened this issue Jan 16, 2025 · 0 comments
Assignees
@d-uspenskiy
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@d-uspenskiy
Copy link
Contributor

d-uspenskiy commented Jan 16, 2025 •
edited
Loading

Jira Link: DB-14902

Description

The following simple modifications of the PgClientSession/PgClientService code reduces the code base, improve readability and simplifies further modifications:

  • Substitute lots of PgClientSession's constructor arguments with single one of newly create type PgClientSessionContext
  • Substitute inheritance from PgClientSession with aggregation and remove all virtual methods.
  • Substitute hand make class DeferredConstructible with std::optional

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@d-uspenskiy d-uspenskiy added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Jan 16, 2025
@d-uspenskiy d-uspenskiy self-assigned this Jan 16, 2025
@d-uspenskiy d-uspenskiy added this to YSQL Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Backlog in YSQL Jan 16, 2025
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Jan 16, 2025
@d-uspenskiy d-uspenskiy changed the title [YSQL] Code cleanup in PgClientSession\PgClientService [YSQL] PgClientSession\PgClientService code cleanup Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-uspenskiy d-uspenskiy

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
YSQL
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @d-uspenskiy