-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance ==
operator to support more types
#2
Comments
Hey! I'd love to work on this. I went through the code base and the majority of changes should be made in |
Hi @siddhantrao23, Yes, you're right. The exact place is where I'd recommend adding tests first (
Thank you! |
@siddhantrao23 Description is updated slightly |
Thanks! I'll start working on it now |
hey @yurtsiv My exams came up so I didn't get to work on this! If there are others, do go ahead. I will contribute after my exams. |
@siddhantrao23 Hi! No problem 🙂 |
Currently
==
only works on integers.We need to implement it for each existing type and it should always compare by value.
Semantics
EDIT:
Since
/=
is already implemented, we should make it work tooThe text was updated successfully, but these errors were encountered: