Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional features #17

Open
stephan281094 opened this issue May 2, 2015 · 1 comment
Open

Additional features #17

stephan281094 opened this issue May 2, 2015 · 1 comment

Comments

@stephan281094
Copy link
Contributor

Hey there,

First of all I'd like to thank you for creating this awesome plugin.
Using this plugin really makes for a great user experience. However, I think Zoomerang lacks some features that would make it even better:

  • Zoom in and out cursor

    When hovering over the element you want to apply zoomerang to, it would be nice to see a zoom-in or zoom-out cursor. It will be easier to understand for the user what's going to happen when they click on it. This is also used on Medium.com.

  • Scrolling event listener

    When the Zoomerang effect is open and the user scrolls, it would be nice to fire the api.close function. To me this really improves the user experience. This is also used on Medium.com.

    Maybe we can have a new option called closeOnScroll that defaults to true (or false) so developers can choose what they prefer.

I'm not sure if you would like to have these features implemented into Zoomerang, but I do think it would be a great addition to an already amazing plugin.

@yyx990803
Copy link
Owner

Sounds great, would happily accept a PR for these features. I'd like closeOnScroll to default to false to make the behavior consistent with older versions though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants