Type "x-www-form-urlencoded" Request Parameters Not Available

[flashvayne]

Description

when I ran a Springboot Service with "logbook-spring-boot-starter",
an error occurred when a "x-www-form-urlencoded" type http request received. The reason is that some parameters from the request were not available. Although I have tried almost every version of "logbook-spring-boot-starter" and changed some environment settings, this problem could not be solved. So, I think there is probably a bug which caused this issue. I have attached the codes that can reproduce this bug. Please refer to Chapter "Steps to Reproduce" and try to reproduce it.

Expected Behavior

Parameters from http request should be available. The error mentioned in Description does not occur when component "logbook-spring-boot-starter" is not used.

Actual Behavior

Parameters from http request were not available. They were all null instead of their original values.

Possible Fix

Steps to Reproduce

Springboot controller code is as below:

@PostMapping("/test")
    public void test(@Param("documentId") String documentId,
                             @Param("result") String result) {
        System.out.println("documentId : " + documentId);
        System.out.println("result : " + result);
    }

Springboot application.yml code is as below:

server:
  port: 8080
logging:
  level:
    org:
      zalando:
        logbook: trace
logbook:
  format:
    style: http

Request curl command is as below:

  curl --location --request POST '127.0.0.1:8080/test' \
  --header 'Content-Type: application/x-www-form-urlencoded' \
  --data-urlencode 'documentId=123456' \
  --data-urlencode 'result=success'

Code "System.out.println" output contents are as below:

documentId : null
result : null

Context

Due to this bug, I had to use InputStream to parse those parameters from http request, which is very complicated.

Your Environment

• Version used: JDK 1.8, Springboot 2.3.0.RELEASE
• Link to your project:

[whiskeysierra]

See https://github.com/zalando/logbook#form-requests as well as #94, #169, #273, #382, #839 and #1051.

[zhfkt]

I tried the following configuration and it seems work.

logbook:
  filter:
    form-request-mode: off

I tried the recommended way to set form-request-mode. Only x-www-form-urlencoded data will not be recorded and other type of post action (such as application/json) will still be logged. So I think it may work currently.