Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replicaCount not being respect #2707

Open
zyue110026 opened this issue Jul 30, 2024 · 4 comments · May be fixed by #2708
Open

replicaCount not being respect #2707

zyue110026 opened this issue Jul 30, 2024 · 4 comments · May be fixed by #2708
Labels
bug

Comments

@zyue110026
Copy link

zyue110026 commented Jul 30, 2024 •
edited
Loading

We have noticed an instance of incorrect helming in one of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

replicaCount does not take effect when changed to a value other than 1. This issue arises due to replicaCount value is hardcoded in deployment.yaml file:

postgres-operator/charts/postgres-operator-ui/templates/deployment.yaml

Line 12 in 73f7241

replicas: 1

Please, answer some short questions which should help us to understand your problem / question better?

  • Which image of the operator are you using?

ghcr.io/zalando/postgres-operator:v1.12.2

  • Where do you run it - cloud or metal? Kubernetes or OpenShift? [AWS K8s | GCP ... | Bare Metal K8s]
    Bare Metal K8s
  • Are you running Postgres Operator in production? [yes | no]
    no
  • Type of issue? [Bug report, question, feature request, etc.]
    Bug report
    Some general remarks when posting a bug report:
  • Please, check the operator, pod (Patroni) and postgresql logs first. When copy-pasting many log lines please do it in a separate GitHub gist together with your Postgres CRD and configuration manifest.
  • If you feel this issue might be more related to the Spilo docker image or Patroni, consider opening issues in the respective repos.
@zyue110026 zyue110026 linked a pull request Jul 30, 2024 that will close this issue
Open
@FxKu
Copy link
Member

FxKu commented Aug 6, 2024

I wonder why this is even configurable? What do we gain by setting the replica count bigger than 1? Availability? It's a simple front end application, after all.

@FxKu FxKu added the bug label Aug 6, 2024
@zyue110026
Copy link
Author

zyue110026 commented Aug 6, 2024 •
edited
Loading

@FxKu It is because you have a

postgres-operator/charts/postgres-operator-ui/values.yaml

Line 5 in ce15d10

replicaCount: 1
in your values.yaml file, which should be considered a configurable value for the availability purpose, if you think configure the replica count number is meaningless, why you add this value in values.yaml file.

@FxKu
Copy link
Member

FxKu commented Aug 6, 2024

The helm charts were for the most part provided by people from the OS community. There might inconsistencies here an there. At Zalando we don't use them so we don't care too much about them.

@zyue110026
Copy link
Author

zyue110026 commented Aug 6, 2024 •
edited
Loading

@FxKu I see, but I still want to collect the practitioners' perceptions of the incorrect helming defect for our research purpose. Do you think it is a bug and will you fix it if you are using that helm chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replicaCount not being respect zyue110026/postgres-operator
2 participants
@FxKu @zyue110026