'Initialization scripts' like in https://hub.docker.com/_/postgres implemented #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberDem0n
suggested changes
Jan 20, 2021
| @@ -1,8 +1,10 @@ | |||
| #!/bin/bash | |||
|
|
|||
| cd "$(dirname "${BASH_SOURCE[0]}")" || exit 1 | |||
| export POSTGRES_USER="$1" | |||
There was a problem hiding this comment.
The first parameter is actually not a postgres user, but HUMAN_ROLE.
| @@ -1,8 +1,10 @@ | |||
| #!/bin/bash | |||
|
|
|||
| cd "$(dirname "${BASH_SOURCE[0]}")" || exit 1 | |||
| export POSTGRES_USER="$1" | |||
| export POSTGRES_DB="$2" | |||
There was a problem hiding this comment.
The second parameter is not the database name, but the connection string in the format "host=localhost port=5432 user=postgres dbname=postgres".
There is one exception though, the post_init.sh could be called from on_role_change.sh. In this case the parameter would be just "postgres".
Comment on lines
+212
to
+214
| ls /docker-entrypoint-initdb.d/ > /dev/null | ||
|
|
||
| docker_process_init_files /docker-entrypoint-initdb.d/* |
There was a problem hiding this comment.
Since in the readme you tell that scripts will be executed only for the new cluster, it makes sense to execute this block only if we know that post_init is not executed from on_role_change:
if [ "$2" != "postgres" ]; then
...
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to add additional script after database initialization.