#466 react on synchronize (#467)

zalando · Oct 27, 2016 · ce66a3c · ce66a3c
1 parent b942593
commit ce66a3c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/server/checks/PullRequestLabels.js b/server/checks/PullRequestLabels.js
@@ -67,7 +67,7 @@ export default class PullRequestLabels extends Check {
     const repoName = repository.name
     const fullName = repository.full_name
     try {
-      if (['labeled', 'unlabeled', 'opened', 'reopened'].indexOf(action) !== -1 && pull_request.state === 'open') {
+      if (['labeled', 'unlabeled', 'opened', 'reopened', 'synchronize'].indexOf(action) !== -1 && pull_request.state === 'open') {
         await this.fetchLabelsAndSetStatus({repository, pull_request, token, config})
       }
     } catch (e) {

diff --git a/server/checks/PullRequestTasks.js b/server/checks/PullRequestTasks.js
@@ -72,7 +72,7 @@ export default class PullRequestTasks extends Check {
     let status;
 
     try {
-      if (pull_request.state === 'open' && ['opened', 'edited', 'reopened'].indexOf(action) !== -1) {
+      if (pull_request.state === 'open' && ['opened', 'edited', 'reopened', 'synchronize'].indexOf(action) !== -1) {
         await this.countTasksAndSetStatus({pull_request, repository, token})
       }
     } catch (e) {

diff --git a/test/server/pullrequestlabels.test.js b/test/server/pullrequestlabels.test.js
@@ -74,8 +74,8 @@ describe('Pull Request Labels', () => {
         }
       }
     }
-    const REACT_ON = ['labeled', 'unlabeled', 'opened', 'reopened']
-    const IGNORE = ['synchronize', 'assigned', 'unassigned', 'closed', 'edited']
+    const REACT_ON = ['labeled', 'unlabeled', 'opened', 'reopened', 'synchronize']
+    const IGNORE = ['assigned', 'unassigned', 'closed', 'edited']
     const ALL = [...REACT_ON, ...IGNORE]
     ALL.forEach(action =>
       it(`ignores everything with state = closed`, async(done) => {

diff --git a/test/server/pullrequesttasks.test.js b/test/server/pullrequesttasks.test.js
@@ -56,8 +56,8 @@ describe('Pull Request Tasks', () => {
       }
     }
     const CONFIG = {}
-    const REACT_ON = ['opened', 'edited', 'reopened']
-    const IGNORE = ['synchronize', 'assigned', 'unassigned', 'closed', 'labeled', 'unlabeled']
+    const REACT_ON = ['opened', 'edited', 'reopened', 'synchronize']
+    const IGNORE = ['assigned', 'unassigned', 'closed', 'labeled', 'unlabeled']
     const ALL = [...REACT_ON, ...IGNORE]
 
     ALL.forEach(action =>