Approval/veto regexes only work for start of comment

[itsthejb]

Hi there,

Trying to use the following config:

approvals:
  minimum: 2
  pattern: ":\\+1:|:pray:|:shipit:|👍|🙏|✅"
  veto:
    pattern: ":\\-1:|👎|❌" # must contain thumbs down or other

i.e. the approvals/vetos can occur anywhere in the comment, not necessarily the start (by removing anchors). This however, appears not to work, even though there would seem to be no limitation on this here.

It would be nice to have this for more expressive messages.

I did a quick test, and it seems (by the unit tests) that it should work: https://github.com/zalando/zappr/compare/master...itsthejb:test-approval-patterns?expand=1. However, in practice it seems not

Hope someone can help!

[itsthejb]

Edit: It seems the issue is that Zappr isn't reading the updated config (on master)