-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Zarr-Python should adopt the Scientific Python spec for minimum supported versions #1616
Comments
Sounds like a good idea to me. |
Hi @jhamman. 👋🏻 Thanks for raising this issue. I've been involved with the good folks over at Scientific Python and added Zarr-Python as one of their core projects and also participating in the SPEC Steering Committee. Recently, I discussed endorsing SPEC0 with the Zarr Steering Council. We discussed dropping Python 3.8 ASAP (@jakirkham thinks we should have done this earlier) and dropping Python 3.9 early next year. Since the SPEC0 recommends dropping Python 3.9 in 2023 Quarter 4 - I wanted to check with the folks over at Scientific Python whether it is acceptable to drop the support beyond the mentioned timeline. Mostly, I think all the active @zarr-developers/python-core-devs are in favour of this decision. But if anyone has any concerns please feel free to raise them here. Additionally, it'd be great if we finish #1557 soon. |
I'm also pro-dropping 3.9 ASAP. (And support SPEC0 in general.) |
Thinking about this a bit more I've come up with this perspective:
|
I don't have a lot of skin in this game but this post on real-world match/case by Ned Batchelder made me more excited to start working on 3.10+ codebases. I suspect that there would be plenty of opportunities to use this in zarr-Python. |
👍 for me, with my only caveat being I think we should decide whether or not this simultaneously applies to numcodecs and if not, what does? cc: @jakirkham |
Since #1557 is completed, I think we should formally endorse SPEC0 alongside other projects. Perhaps a discussion on numcodecs during this week's community meeting (1/24) might be a good idea if all can make it. |
Let's make v3.0 will be 3.10+ |
Can I suggest it should by 2.17 since 3.8 was dropped? Otherwise, 👍 |
After a discussion with the good folks at Scientific Python, it was clear that we could endorse SPEC0 before the next release. The SPEC documents are more of a recommendation for scientific projects than bylaws. Since we already have a consensus among us and after talking to @jhamman and @d-v-b at the Zarr Sprint today and @joshmoore at the community meeting, I've gone ahead and sent a PR to endorse SPEC0 here: scientific-python/specs#299. Please approve the PR or react with |
@MSanKeys963 - to close this out, would you mind adding a note to the installation docs page noting the version support policy: https://zarr.readthedocs.io/en/stable/installation.html |
It would be nice if Zarr-Python had a clear process for determining what the minimum supported versions of various dependencies were. The Scientific Python project developed a spec for just this purpose: https://scientific-python.org/specs/spec-0000/. The relevant part for us is when to drop support for old versions of Python and Numpy. The spec defines support windows as:
So three years for Python and two years for NumPy.
I propose we adopt this spec. In the short term, that would mean we drop support for Python 3.8 and shortly thereafter 3.9. We would also benefit from a CI environment that tests against old version of NumPy and other optional dependencies.
The text was updated successfully, but these errors were encountered: