-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Host.AzureServiceBus] Pass ServiceProvider as arg to client factory #343
Comments
…tory Signed-off-by: Richard Pringle <[email protected]>
Signed-off-by: Richard Pringle <[email protected]>
Do we want to keep this issue open for other Aspire aligning work? |
I'm going to stop here as integration could not be simpler. If interested, I've thrown up a quick spike to demonstate usage (including distributed tracing). |
Ok I will have a look. Perhaps we could link to this from the SMB docs. |
I have no objection to that, but please feel free to bring it into your repo (in whole or in pieces). It would probably be better to keep the samples together. I've only spent about 2 hours looking into Aspire so far, so it may not be the best implementation ...but it works at least, and with minimal effort :) |
Factories for both
ServiceBusClient
andServiceBusAdministrationClient
exist inHost.AzureServiceBus
transport already, but do not passIServiceProvider
to the factory.I have barely scrathed the surface but it appears to be only stumbling block for integrating with Aspire at this point. Either way, it is a minor change that will improve the flexibility of the factories.
The text was updated successfully, but these errors were encountered: