Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Host.AzureServiceBus] Pass ServiceProvider as arg to client factory #343

Open
EtherZa opened this issue Nov 17, 2024 · 4 comments
Open

Comments

@EtherZa
Copy link
Contributor

EtherZa commented Nov 17, 2024

Factories for both ServiceBusClient and ServiceBusAdministrationClient exist in Host.AzureServiceBus transport already, but do not pass IServiceProvider to the factory.

I have barely scrathed the surface but it appears to be only stumbling block for integrating with Aspire at this point. Either way, it is a minor change that will improve the flexibility of the factories.

EtherZa added a commit to EtherZa/SlimMessageBus that referenced this issue Nov 17, 2024
zarusz pushed a commit that referenced this issue Nov 17, 2024
@zarusz
Copy link
Owner

zarusz commented Nov 17, 2024

Do we want to keep this issue open for other Aspire aligning work?

@EtherZa
Copy link
Contributor Author

EtherZa commented Nov 18, 2024

I'm going to stop here as integration could not be simpler. If interested, I've thrown up a quick spike to demonstate usage (including distributed tracing).

@zarusz
Copy link
Owner

zarusz commented Nov 18, 2024

Ok I will have a look. Perhaps we could link to this from the SMB docs.

@EtherZa
Copy link
Contributor Author

EtherZa commented Nov 18, 2024

I have no objection to that, but please feel free to bring it into your repo (in whole or in pieces). It would probably be better to keep the samples together.

I've only spent about 2 hours looking into Aspire so far, so it may not be the best implementation ...but it works at least, and with minimal effort :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants