Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error stuck when working with monorepo #19387

Closed
1 task done
aevsai opened this issue Oct 17, 2024 · 3 comments
Closed
1 task done

Error stuck when working with monorepo #19387

aevsai opened this issue Oct 17, 2024 · 3 comments
Labels
bug [core label] eslint ESLint tooling support language server failure Language server doesn't work as expected typescript TypeScript programming language support

Comments

@aevsai
Copy link

aevsai commented Oct 17, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Hi, I have encountered with annoying issue that fixed error remains highlighted. I am using pnpm and turborepo for workspace management. I have local packages that is being rebuilt on changes and app that uses them.

How to reproduce error:

  1. open zed
  2. run turborepo with app that depends on a local package build
  3. use something from the local package and you would get error as it not imported
    Screenshot 2024-10-17 at 20 28 12
  4. import the required item from the package, but you get another error saying it is not exported
    Screenshot 2024-10-17 at 20 06 22
  5. add the export in the package. since the package’s code has changed, turborepo will rebuild it
  6. return to you file. the import error is resolved and is no longer highlighted in import line, but the line where imported element being used still highlighted
    Screenshot 2024-10-17 at 20 28 50
  7. close and reopen zed, line is not highlighted anymore
    Screenshot 2024-10-17 at 20 31 32

And one more fact: if element was exported before zed was open, everything works just fine

Environment

Zed: v0.157.5 (Zed)
OS: macOS 14.6.1
Memory: 18 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

zed-2.log
zed.log

@aevsai aevsai added admin read bug [core label] labels Oct 17, 2024
@notpeter notpeter added typescript TypeScript programming language support eslint ESLint tooling support language server failure Language server doesn't work as expected and removed triage labels Oct 17, 2024
@aevsai
Copy link
Author

aevsai commented Oct 31, 2024

btw helps reloading language server with shift+cmd+p -> restart language server

@baptisteArno
Copy link

Most likely related #18698

@aevsai
Copy link
Author

aevsai commented Feb 24, 2025

Issue not stuck anymore after adjusting settings and reloading workspace:

"lsp": {
  "vtsls": {
     "settings": {
       "tsserver": {
         "maxTsServerMemory": 8092
       }
     }
   }
}

@aevsai aevsai closed this as completed Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] eslint ESLint tooling support language server failure Language server doesn't work as expected typescript TypeScript programming language support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants