Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow completions/suggestions (Typescript) #20715

Open
1 task done
Iliasnolsson opened this issue Nov 15, 2024 · 5 comments
Open
1 task done

Slow completions/suggestions (Typescript) #20715

Iliasnolsson opened this issue Nov 15, 2024 · 5 comments
Labels
autocompletions Feedback for code completions in the editor bug [core label] language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors performance Feedback for performance issues, speed, memory usage, etc typescript TypeScript programming language support

Comments

@Iliasnolsson
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Completions for typescript has become a lot better with Zed preview v0.162.1, but the time in which it takes for completions to show up while typing is too long. Attached is a video showcasing this. Both editors shown in the video uses the same repository (a 107,5 MB monorepo).

It would be great if it is possible to make this faster.

  • Top editor in the video is zed
  • Bottom editor in the video is visual studio code

Here is my settings for zed:

{
    "features": {
        "inline_completion_provider": "none"
    },
    "base_keymap": "VSCode",
    "theme": "VSCode Dark Modern",
    "ui_font_size": 12,
    "buffer_font_size": 13,
    "tab_size": 4,
    "formatter": "language_server",
    "autosave": {
        "after_delay": {
            "milliseconds": 800
        }
    },
    "show_signature_help_after_edits": false,
    "eslint": {
        "enabled": false
    },
    "completion_documentation_secondary_query_debounce": 0
}

Here is the video:

Example.mov

__

Environment

Zed: v0.162.1 (Zed Preview)
OS: macOS 15.1.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

@Iliasnolsson Iliasnolsson changed the title Slow completions (Typescript) Slow completions/suggestions (Typescript) Nov 15, 2024
@Iliasnolsson
Copy link
Author

Check out this video. I discovered that the time it takes for completions to show up significantly increases if the value of the other parameters of the function are set to somthing other that simply null!

Screen.Recording.2024-11-16.at.22.54.14.mov

@Iliasnolsson
Copy link
Author

Have tested this with the same code in the latest Zed version (0.164.0). Has the same behaviour as shown in videos (version v0.162.1)

@JosephTLyons JosephTLyons added performance Feedback for performance issues, speed, memory usage, etc typescript TypeScript programming language support language An umbrella label for all programming languages syntax behaviors language server An umbrella label for all language servers autocompletions Feedback for code completions in the editor and removed triage labels Dec 3, 2024
@Iliasnolsson
Copy link
Author

Have tested this with the same code in the latest Zed version (0.167.0). Has the same behaviour as shown in videos (version v0.162.1)

@Iliasnolsson
Copy link
Author

Have tested this with the same code in the latest Zed version (0.170.0). Has the same behaviour as shown in videos (version v0.162.1)

@baptisteArno
Copy link

Related #18698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocompletions Feedback for code completions in the editor bug [core label] language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors performance Feedback for performance issues, speed, memory usage, etc typescript TypeScript programming language support
Projects
None yet
Development

No branches or pull requests

3 participants