Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The chat panel font size is extremely small and unreadable and there is no way to change it #21037

Open
1 of 4 tasks
nirs opened this issue Nov 22, 2024 · 4 comments · May be fixed by #21225
Open
1 of 4 tasks

The chat panel font size is extremely small and unreadable and there is no way to change it #21037

nirs opened this issue Nov 22, 2024 · 4 comments · May be fixed by #21225
Labels
admin read Pending admin review chat Feedback for chat and messaging collaboration features font Font feedback for readability, size, style, etc triage Maintainer needs to classify the issue

Comments

@nirs
Copy link

nirs commented Nov 22, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

The chat panel font size is tiny and barely readable. It cannot be configured by buffer_font_size or ui_font_size (also tried terminal:font_size). There is no way to increase the size (e.g. Zoom In).

Changes needed:

  • Use the same default used for buffers
  • Add configuration for chat font size
  • Make it behave like buffers - Zoom In/Out should work

Environment

Zed: v0.162.3 (Zed)
OS: macOS 15.1.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Note: the screenshot may seem usable if you use use Zoom != 100% in your browser.

Screenshot 2024-11-22 at 2 57 49

If applicable, attach your Zed.log file to this issue.

Zed.log
@nirs nirs added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Nov 22, 2024
@notpeter notpeter added font Font feedback for readability, size, style, etc chat Feedback for chat and messaging collaboration features accessibility Improvement related to color contrast, screen reader support, keyboard navigation, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 26, 2024
@notpeter
Copy link
Member

Potential workaround via settings:

  "ui_font_size": 24,

@notpeter
Copy link
Member

Closing as duplicate of:

@notpeter notpeter closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
@notpeter notpeter added duplicate Additional reports of an existing issue and removed bug [core label] font Font feedback for readability, size, style, etc accessibility Improvement related to color contrast, screen reader support, keyboard navigation, etc chat Feedback for chat and messaging collaboration features labels Nov 26, 2024
@nirs
Copy link
Author

nirs commented Nov 26, 2024

Potential workaround via settings:

  "ui_font_size": 24,

Thanks but this is way to big. To get usable size for the chat 20pt works, but it is also too big, 16 looks great the the UI.

Screenshot 2024-11-26 at 21 40 21

nirs added a commit to nirs/zed that referenced this issue Nov 26, 2024
@nirs
collab: Use ui_font_size
99fd89c 
Current chat panel font size is tiny and not usable for anyone. To make
it useable we can increase the ui_font_size setting, but this makes the
ui too big. The ui looks great with the default size, so lets make the
chat look good with the default setting.

Change the chat panel to use to ui font size:
- Change items using text_ui_sm and text_ui_xx to text_ui
- Change LabelSize::Small to LabelSize:Default

I kept LabelSize:Small for text about delete message. This is a case
when we can use smaller font size.

Maybe we can tweak some items to use little bit smaller font later.

Fixes zed-industries#21037

Release Notes:

- Collab panel readability improved to use the ui_font_size setting.
@nirs nirs linked a pull request Nov 26, 2024 that will close this issue
Draft
@nirs
Copy link
Author

nirs commented Nov 26, 2024

@notpeter The duplicate issues does not seem to cover all the changes needed, so I sent a draft implementing the first part, using better defaults. Maybe reopen this issue?

nirs added a commit to nirs/zed that referenced this issue Nov 26, 2024
@nirs
collab: Use ui_font_size
1242dcf 
Current chat panel font size is tiny and not usable for anyone. To make
it useable we can increase the ui_font_size setting, but this makes the
ui too big. The ui looks great with the default size, so lets make the
chat look good with the default setting.

Change the chat panel to use to ui font size:
- Change items using text_ui_sm and text_ui_xs to text_ui
- Change LabelSize::Small to LabelSize:Default

I kept LabelSize:Small for text about delete message. This is a case
when we can use smaller font size.

Maybe we can tweak some items to use little bit smaller font later.

Fixes zed-industries#21037

Release Notes:

- Collab panel readability improved to use the ui_font_size setting.
@notpeter notpeter reopened this Nov 28, 2024
@notpeter notpeter added font Font feedback for readability, size, style, etc chat Feedback for chat and messaging collaboration features and removed duplicate Additional reports of an existing issue labels Nov 28, 2024
@github-actions github-actions bot added admin read Pending admin review triage Maintainer needs to classify the issue labels Nov 28, 2024
This was referenced Nov 28, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin read Pending admin review chat Feedback for chat and messaging collaboration features font Font feedback for readability, size, style, etc triage Maintainer needs to classify the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ui_font_size in chat panel nirs/zed
2 participants
@notpeter @nirs