Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error and warning indicators in tabs #21179

Open
1 task done
nilskch opened this issue Nov 25, 2024 · 1 comment · May be fixed by #21383
Open
1 task done

Show error and warning indicators in tabs #21179

nilskch opened this issue Nov 25, 2024 · 1 comment · May be fixed by #21383
Labels
diagnostics Feedback for diagnostics, error messages, logs, etc enhancement [core label] tabs Feedback for tabs behavior, navigation, style, etc

Comments

@nilskch
Copy link
Contributor

nilskch commented Nov 25, 2024 •
edited
Loading

Check for existing issues

  • Completed

Describe the feature

In #18182, we introduced diagnostics to the project panel using a DecoratedIcon with X or triangle decorations for errors and warnings. It would be great to also show diagnostics in the tab bar as well, using the same approach. I would also use the same setting we used in the "project_panel".

{
  "tabs": {
    // "all" / "errors" / "off"
    "show_diagnostics": "all"
  }
}

I am happy to implement this feature if you would want to add this to Zed.

Environment

Zed: v0.163.2 (Zed Preview)
OS: macOS 15.1.1
Memory: 18 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help present your vision of the feature

tabs
@nilskch nilskch added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Nov 25, 2024
@notpeter notpeter added tabs Feedback for tabs behavior, navigation, style, etc diagnostics Feedback for diagnostics, error messages, logs, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 25, 2024
@github-actions github-actions bot mentioned this issue Nov 26, 2024
Open
@nilskch
Copy link
Contributor Author

nilskch commented Nov 27, 2024

@danilo-leal @iamnbutler what do you think about this? This would be relatively easy to implement since we can copy the design from the project panel.

@nilskch nilskch linked a pull request Dec 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diagnostics Feedback for diagnostics, error messages, logs, etc enhancement [core label] tabs Feedback for tabs behavior, navigation, style, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show error and warning indicators in tabs nilskch/zed
2 participants
@notpeter @nilskch