Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to open permalink to line for organization-specific SSH username remotes #21507

Closed
1 task done
nickbreaton opened this issue Dec 4, 2024 · 1 comment · Fixed by #21508
Closed
1 task done

Failure to open permalink to line for organization-specific SSH username remotes #21507

nickbreaton opened this issue Dec 4, 2024 · 1 comment · Fixed by #21508
Labels
bug [core label] git Git integration feedback

Comments

@nickbreaton
Copy link
Contributor

nickbreaton commented Dec 4, 2024 •
edited
Loading

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

My work's organization using GitHub has a specific username for cloning repositories other than git. I can't find any clear cut documentation on what this is used for, but see attached screenshot for an example:

clone instructions

When executing the "editor: open permalink to line" command, it fails with:

Failed to open permalink: failed to parse Git remote URL

Environment

Zed: v0.163.3 (Zed)
OS: macOS 15.1.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@nickbreaton nickbreaton added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Dec 4, 2024
@nickbreaton nickbreaton mentioned this issue Dec 4, 2024
Merged
@nickbreaton
Copy link
Contributor Author

nickbreaton commented Dec 4, 2024 •
edited
Loading

Tried my hand at fixing in #21508, happy to accommodate any feedback there!

This is my first issue and PR to Zed. Been loving the project so far, but this makes it hard for me to use at work.

@nickbreaton nickbreaton changed the title Failure to open permalink to line for organization-specific SSH usernames Failure to open permalink to line for organization-specific SSH username remotes Dec 4, 2024
@notpeter notpeter added git Git integration feedback and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [core label] git Git integration feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect wider variety of usernames for SSH-based remotes nickbreaton/zed
2 participants
@notpeter @nickbreaton