Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DPI scale factor when window is moved to a different X11 output #21851

Open
1 task done
jansol opened this issue Dec 11, 2024 · 2 comments
Open
1 task done

Update DPI scale factor when window is moved to a different X11 output #21851

jansol opened this issue Dec 11, 2024 · 2 comments
Labels
enhancement [core label] gpui GPUI rendering framework support linux-x11 Linux X11

Comments

@jansol
Copy link
Contributor

jansol commented Dec 11, 2024

Check for existing issues

  • Completed

Describe the feature

Apparently that is not being done right now, as per #21816 . I remember seeing winit do this way back when I still used X11 so it should be possible?

Environment

Linux/X11

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@jansol jansol added enhancement [core label] admin read Pending admin review gpui GPUI rendering framework support linux-x11 Linux X11 labels Dec 11, 2024
@notpeter
Copy link
Member

notpeter commented Dec 11, 2024

I think these are required APIs. Not sure exactly how to determine when a given Zed window is "on" a given display. Currently scaling (ui_font_size / buffer_font_size / zoom) are global across a given Zed process and cannot be adjusted per-window.

X11:

Wayland:

macOS:

@notpeter notpeter removed the admin read Pending admin review label Dec 11, 2024
@jansol
Copy link
Contributor Author

jansol commented Dec 11, 2024

I believe on macOS one should simply use the NSWindow backing store scale as that also accounts for user-configured display scaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] gpui GPUI rendering framework support linux-x11 Linux X11
Projects
None yet
Development

No branches or pull requests

2 participants