Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When expanding excerpts in multi-buffer overlapping excerpts within the same file should merge into one #21864

Closed
1 task done
exalted opened this issue Dec 11, 2024 · 5 comments
Closed
1 task done

When expanding excerpts in multi-buffer overlapping excerpts within the same file should merge into one #21864

exalted opened this issue Dec 11, 2024 · 5 comments
Labels
duplicate Additional reports of an existing issue

Comments

@exalted
Copy link
Contributor

exalted commented Dec 11, 2024 •
edited
Loading

Check for existing issues

  • Completed

Found:

Describe the bug / provide steps to reproduce it

When expanding excerpts in a multi-buffer, overlapping excerpts (line number-wise) within the same file should merge into one. Otherwise, it gets confusing to parse, visually speaking, the multi-buffer with repeating lines.

Environment

Zed: v0.165.4 (Zed Preview)
OS: macOS 15.1.1
Memory: 64 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

CleanShot 2024-12-11 at 17 32 07@2x

If applicable, attach your Zed.log file to this issue.

Zed.log
@exalted exalted added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Dec 11, 2024
@filipwiech
Copy link

See also #13513. 😉

@exalted
Copy link
Contributor Author

exalted commented Dec 11, 2024

@filipwiech thanks! I searched all the issues, but that issue didn't use the term excerpt, so I couldn't find it. ✌️

@filipwiech
Copy link

No problem at all, just wanted to link the issues together. 🙂 Also, this might be even more relevant now, looking at the upcoming git diff view based on the multi-buffer (#21543). 👍

@exalted
Copy link
Contributor Author

exalted commented Dec 11, 2024 via email

@jansol
Copy link
Contributor

jansol commented Dec 11, 2024

Closing as a duplicate of #13513

@jansol jansol closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@jansol jansol added duplicate Additional reports of an existing issue and removed bug [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Additional reports of an existing issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@exalted @jansol @filipwiech