Cmd+click on a file with a line from iTerm2 should open to that line

[hgezim]

Check for existing issues

• Completed

Describe the feature

It currently opens the file but not to the line.

Zed Version and System Specs

Zed: v0.168.2 (Zed)
OS: macOS 14.6.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help present your vision of the feature

No response

[SomeoneToIgnore]

We do have such functionality overall, here's a recent addition to that, for example: #22559

So, can you provide more details: which kind of link that is, where it's open, etc.

[hgezim]

Format: lib/phapi_web/components/profile_menu_component.ex:103:16

[SomeoneToIgnore]

regular.project.mov

Just to note, it works just fine in regular Zed project: clicks do open the file at the correct location.

So, without extra details it's not quite clear what's broken.

[CharlesChen0823]

this is because the path is lib/phapi_web/components/profile_menu_component.ex:103:16:, one more : in the path end, which not support open.

[SomeoneToIgnore]

Great point about the trailing : but I think

which not support open.

is wrong, unless I'm doing something odd: I've created a dummy file with the exact same path and pasted lib/phapi_web/components/profile_menu_component.ex:103:16: into a file that I cat inside the terminal: works for me just fine.

odd.mov

[CharlesChen0823]

sorry, it's my previous operator error. i cannot reproduce that

[bennetbo]

When using the integrated terminal this works as expected, but not when clicking on links inside a standalone iTerm2 application (i think this might be what the issue is about).

Screen.Recording.2025-01-13.at.11.27.22.mov

Not sure why this is not working for zed, need to investigate this more. In the meantime you can follow this workaround posted here, which makes zed work as expected.

[SomeoneToIgnore]

Great point that it's iTerm2 external click -> Zed opening, I've totally missed that.

Then, it's handled by the OS which expects an application (which zed CLI is not) to open any link clicked:

That is handled in

zed/crates/gpui/src/platform/mac/platform.rs

Lines 1359 to 1373 in 1467d8b

	extern "C" fn open_urls(this: &mut Object, _: Sel, _: id, urls: id) {
	let urls = unsafe {
	(0..urls.count())
	.filter_map(|i| {
	let url = urls.objectAtIndex(i);
	match CStr::from_ptr(url.absoluteString().UTF8String() as *mut c_char).to_str() {
	Ok(string) => Some(string.to_string()),
	Err(err) => {
	log::error!("error converting path to string: {}", err);
	None
	}
	}
	})
	.collect::<Vec<_>>()
	};

If I add

log::error!("$$$?: absoluteString: {string:?}");

change inside filter_map after retrieving that property, I see

$$$?: absoluteString: "file:///Users/someonetoignore/work/zed/zed/crates/editor/src/inlay_hint_cache.rs"

in my logs when clicking thread 'inlay_hint_cache::tests::test_large_buffer_inlay_requests_split' panicked at crates/editor/src/inlay_hint_cache.rs:2333:17: in iTerm2.

Not sure what to try after that:
https://developer.apple.com/documentation/appkit/nsapplicationdelegate/application(_:open:)?language=objc
mentions it's NSURL we get:
https://developer.apple.com/documentation/foundation/nsurl?language=objc

but all my attempts to read other data from this URL ended up with nothing that resembles the suffix: port is 0, query() call segraults, etc.

Interesting to note, that VSCode as a default app for *.rs opening, manages to handle this right.

[hgezim]

Workaround works great:

/usr/local/bin/zed \1:\2