copilot_chat: Rename o1-preview model to o1
#23038
Conversation
Rename the `O1Preview` variant to `O1` in the `Model` enum and update related functions in `crates/copilot/src/copilot_chat.rs`. * Change the `Model` enum to rename the `O1Preview` variant to `O1`. * Update the `from_id` function to map the string "o1" to the `O1` variant. * Update the `id` function to return "o1" for the `O1` variant. * Update the `display_name` function to return "o1" for the `O1` variant. * Update the `max_token_count` function to return 20000 for the `O1` variant.
Rename O1Preview variant to O1 in copilot chat
|
We require contributors to sign our Contributor License Agreement, and we don't have @SkywardSyntax on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
|
@SkywardSyntax Thanks for opening this. One thing I noticed is that in Zed syntax highlighting is incorrect for the 
This is because of the following query: zed/crates/languages/src/rust/highlights.scm Lines 49 to 51 in 94f106d Not sure if it's worth fixing/working around, but just wanted to mention it. |
maxdeviant
changed the title
o1-preview model to o1
|
@notpeter : But it looks like |
The regex is: Which is all capital letters, underscores or digits beginning with at least one letter prefixed by 0 or more underscores. I think we just need to be smarter about tree-sitter contexts so that Enum values are not considered by this It seems reasonable to me that with |
https://github.blog/news-insights/openais-o1-model-available-in-copilot-chat-and-github-models/
Release Notes: