Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strider plugin could panic when sending ESC twice #2703

Open
Kangaxx-0 opened this issue Aug 18, 2023 · 0 comments · May be fixed by #2702
Open

Strider plugin could panic when sending ESC twice #2703

Kangaxx-0 opened this issue Aug 18, 2023 · 0 comments · May be fixed by #2702

Comments

@Kangaxx-0
Copy link
Contributor

Sample layout

layout {
    pane size=1 borderless=true {
        plugin location="zellij:tab-bar"
    }
     pane  split_direction="Vertical"{
      pane size="50"{
        plugin location="zellij:strider"
      }
      pane
     }
    pane size=2 borderless=true {
        plugin location="zellij:status-bar"
    }
}

Repo steps:

  1. Use above code as default layout and start zellij, wait strider plugin loads successfully.
  2. Hit ESC -> notice the plugin is not suppressed
  3. Hit ESC again -> Zellij crashed

The root cause is - When we issue the ESC for the first time, the plugin pane is removed from tiled_pane and should lose the focus, on the other hand, plugin strider the pane is fixed, it could not grow

@Kangaxx-0 Kangaxx-0 linked a pull request Aug 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant