Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete JPEG-XL Support #726

Closed
gianni-rosato opened this issue Aug 26, 2024 · 13 comments · May be fixed by #5634
Closed

Complete JPEG-XL Support #726

gianni-rosato opened this issue Aug 26, 2024 · 13 comments · May be fixed by #5634

Comments

@gianni-rosato
Copy link

What feature would you like to see?

Currently, there is a flag disabled by default to support the JPEG-XL image format which works similarly to Firefox Nightly. This is great! However, there's a bit more to the story when it comes to complete JXL support:

  • Firefox Nightly stopped maintaining their JPEG-XL support when the Chrome team made the controversial decision not to support JPEG-XL
  • Since then, a the patchset has evolved to provide full JPEG-XL support without bugs. Bugs in the current implementation include:
    • Broken animation
    • Broken transparency
    • Improper color profile handling
  • Browsers such as Waterfox, Floorp, and r3dfox have implemented the patches fully. In order to test this, you can use this JPEG-XL test page.

Other details

Here's a proper implementation (via Waterfox):

waterfox_jxl

And here's Zen's current implementation (presumably carried over from Firefox Nightly):

zen_jxl

I think it is super awesome that the JPEG-XL flag is enabled in the first place, but this is an opportunity to go the extra mile for JXL support as it continues to improve elsewhere. The entire Apple ecosystem supports JPEG-XL, and Cloudinary cites serving billions of JPEG-XL images regularly. In addition, there are rumors that the iPhone 16 may shoot JPEG-XL images by default.

If you're interested in making this work, I can point you in the direction of the patchset & connect you with some developers who may be interested in helping make this work. Zen is really cool by the way, and given this issue is addressed, I'll happily switch from Waterfox to Zen without question! Thanks for your great work!

@mauro-balades
Copy link
Member

This is fixed for the next release

@junedabat
Copy link

As of 1.0.0-a.35, JPEG-XL support still isn't enabled by default for me.

image

Setting the image.jxl.enabled flag in about:config to true manually does enable it, but animated JPEG-XLs don't work.

Essentially, the problem is the same.
image

@zzzsyyy
Copy link

zzzsyyy commented Sep 15, 2024

As of 1.0.0-a.39, the jxl support is still incomplete

@onzecki
Copy link

onzecki commented Sep 27, 2024

This is fixed for the next release

JXL is now indeed enabled by default but it still lacks the patches needed for the aforementioned issues to be fixed. Check the JPEG XL test page to see it yourself.
The issue isn't quite yet resolved.

@nocanoa
Copy link
Member

nocanoa commented Sep 27, 2024

@onzecki are the patches in ff under a about:config flag? or wold we need to do it ourselvs?

@onzecki
Copy link

onzecki commented Sep 27, 2024

@onzecki are the patches in ff under a about:config flag? or wold we need to do it ourselvs?

As @gianni-rosato mentioned, they're not under FF sadly, however several Firefox forks, (Waterfox f.e., as mentioned) have applied patches for animations, transparency, color profiles and more to work correctly

@gianni-rosato
Copy link
Author

JXL support continues to be incomplete in 1.0.1-a.7. I think this should be reopened, as the initial issue still exists; any updates?

@mauro-balades
Copy link
Member

It would be great if you could send those patches other forks do to have complet jxl

@junedabat
Copy link

junedabat commented Oct 9, 2024

Here's the history of patches relating to the JXL library in Waterfox : https://github.com/BrowserWorks/Waterfox/commits/current/third_party/jpeg-xl

And here's the link to the JXL lib, https://github.com/libjxl/libjxl/tree/main/lib/jxl

I don't know if this is enough to be any helpful

@onzecki
Copy link

onzecki commented Oct 9, 2024

I also found this resource describing the patches, which might be useful: https://discussion.fedoraproject.org/t/introducing-a-firefox-package-with-jpeg-xl-enabled/117139

@zzzsyyy
Copy link

zzzsyyy commented Oct 9, 2024

@onzecki
Copy link

onzecki commented Dec 13, 2024

This still isn't fixed, I think the issue should definitely be reopened @mr-cheff

@mauro-balades
Copy link
Member

Firefox needs to finish support for animated jxls yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@onzecki @gianni-rosato @zzzsyyy @mauro-balades @junedabat @nocanoa and others